[for review] 6948144: jpkg throws NPE if resource directory does not exist

[Dalibor Topic]

Alan Bateman wrote:
> Dalibor Topic wrote:
>> Hi Alan,
>>
>> thanks for reporting a NPE with
>> $ jpkg -m existing-dir -r non-existing-dir jmod some-mod
>>
>> the fix is easy - test whether the resource path exists before passing
>> it on to module file writer ;) The webrev is at
>> http://cr.openjdk.java.net/~robilad/6948144/webrev.00/
>>
>> Once this one is in, I'll commit similar tests for the remaining
>> parameters.
>>
>> cheers,
>> dalibor topic
>>   
> The fix looks OK to me. I'm not sure about the name of the test though
> as it doesn't seem to be consistent with the other tests. In time it can
> be useful to expand existing tests with additional tests.

How about calling is JpkgTestInputParameters? Then expanding the
test to cover more of the cases will feel rather natural.

cheers,
dalibor topic

-- 
*******************************************************************
Dalibor Topic                   Tel: (+49 40) 23 646 738
Java F/OSS Ambassador           AIM: robiladonaim
Sun Microsystems GmbH           Mobile: (+49 177) 2664 192
Nagelsweg 55                    http://openjdk.java.net
D-20097 Hamburg                 mailto:Dalibor.Topic at sun.com
Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Amtsgericht München: HRB 161028
Geschäftsführer: Jürgen Kunz