Review request for generating debian package for jdk modules

Dalibor Topic Dalibor.Topic at Sun.COM
Mon Feb 15 15:43:53 PST 2010


Mandy Chung wrote:
> This change will generate debian packages for jdk modules.
> 
> Webrev at:
>   http://cr.openjdk.java.net/~mchung/jigsaw/jigsaw-deb-pkgs/
> 
> Summary:
> 1. Include unpack200 in the jdk.boot module depended by
>   the install script to uncompress the jpg generated packages.

Looks good as well.
> 
> 3. BuildPackages.gmk is the makefile for building packages.
>   Currently it checks if it's running on debian systems or not.
>   If not, no package will be generated.  This gmk file will   be
> modified when jpkg is extended to support other native
>   packaging format or module neutral format.

Small nit: you'll only need to pass -c to jpkg if there is 
something with a main class in a module to run - I assume that's 
not the case for the jdk modules? Otherwise, it looks fine, too.

cheers,
dalibor topic

-- 
*******************************************************************
Dalibor Topic                   Tel: (+49 40) 23 646 738
Java F/OSS Ambassador           AIM: robiladonaim
Sun Microsystems GmbH           Mobile: (+49 177) 2664 192
Nagelsweg 55                    http://openjdk.java.net
D-20097 Hamburg                 mailto:Dalibor.Topic at sun.com
Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Amtsgericht München: HRB 161028
Geschäftsführer: Thomas Schröder, Wolfgang Engels
Vorsitzender des Aufsichtsrates: Martin Häring





More information about the jigsaw-dev mailing list