Review request for generating debian package for jdk modules

[Mandy Chung]

On 02/15/10 15:43, Dalibor Topic wrote:
> Mandy Chung wrote:
>> This change will generate debian packages for jdk modules.
>>
>> Webrev at:
>>   http://cr.openjdk.java.net/~mchung/jigsaw/jigsaw-deb-pkgs/
>>
>> Summary:
>> 1. Include unpack200 in the jdk.boot module depended by
>>   the install script to uncompress the jpg generated packages.
> 
> Looks good as well.
>> 3. BuildPackages.gmk is the makefile for building packages.
>>   Currently it checks if it's running on debian systems or not.
>>   If not, no package will be generated.  This gmk file will   be
>> modified when jpkg is extended to support other native
>>   packaging format or module neutral format.
> 
> Small nit: you'll only need to pass -c to jpkg if there is 
> something with a main class in a module to run - I assume that's 
> not the case for the jdk modules? Otherwise, it looks fine, too.

Right.  -c option is not needed for jdk modules.  I will take that out.

Thanks for the review, Dalibor.
Mandy

> cheers,
> dalibor topic
>