Review request: jdk jtreg testing with jdk-module-image

[Alan Bateman]

Mandy Chung wrote:
> Webrev:
>   http://cr.openjdk.java.net/~mchung/jigsaw/jprt-jigsaw-tests/forest
>   http://cr.openjdk.java.net/~mchung/jigsaw/jprt-jigsaw-tests/jdk/
>
> With this fix, we can run the jdk test targets with the 
> jdk-module-image from making jdk/test/Makefile or in a jprt job.   
> This also adds a new jdk_jigsaw test target for testing module image.
>
> I add a new "modules" keyword and the test/Makefile will set the 
> keyword to exclude modules tests if testing a legacy image.  The 
> java/lang/module and java/lang/reflect/Module jtreg tests are tagged 
> with the new "modules" keyword since these tests are included in 
> jdk_lang target and also jdk_jigsaw is included in the jprt test targets.
>
> test/ModulesProblemList.txt is intended for temporarily use.  Some of 
> the failures are known issues that should be fixed soon.
I did a pass over this.  It mostly looks good to me.

In test/Makefile would it be more readable/consistent to use 
MODULE_BUILD instead of TEST_MODULES to indicate that it's a modules 
build? Minor nit is that a spurious blank line is added at line 347.

In jprt.properties I see you've removed the fastdebug build from the 
list of flavors. Is that intended?

Finally, did you mean to include the new tests and fixes to the other 
tests in this webrev? I look through them and they look good.

-Alan.