jmod enhancements to support signed modules
    Dalibor Topic 
    Dalibor.Topic at Sun.COM
       
    Mon Jun  7 09:01:20 PDT 2010
    
    
  
Vincent Ryan wrote:
> Thanks for your comments Sean.
> 
> I've made the changes you suggest except for removing PKCS7VerifierParameters
> class because it is used by the ModuleFormatTest01 unit test.
> 
> An updated webrev is available at:
> 
> http://cr.openjdk.java.net/~vinnie/6957907/webrev.01/
Looks good to me, small nits:
ModuleFileFormat:
* import cleanup: 
I guess the  import java.security.cert.Certificate; could go away, too?
* loadCACertsStore:
Not sure about the unix file separators and the file location on windows
- if the file name is used across tests & further code, it may make sense
to add it to Files.java.
* SimpleLibrary
indentation : 
+            if (doVerify) {
             mr.verifyHashes();
+            }
cheers,
dalibor topic
-- 
*******************************************************************
Dalibor Topic                   Tel: (+49 40) 23 646 738
Java F/OSS Ambassador           AIM: robiladonaim
Sun Microsystems GmbH           Mobile: (+49 177) 2664 192
Nagelsweg 55                    http://openjdk.java.net
D-20097 Hamburg                 mailto:Dalibor.Topic at sun.com
Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Amtsgericht München: HRB 161028
Geschäftsführer: Jürgen Kunz
    
    
More information about the jigsaw-dev
mailing list