jmod enhancements to support signed modules

[Vincent Ryan]

Thanks for the quick turnaround Dalibor. I've a few responses below.


On 07/06/2010 17:01, Dalibor Topic wrote:
> Vincent Ryan wrote:
>> Thanks for your comments Sean.
>>
>> I've made the changes you suggest except for removing PKCS7VerifierParameters
>> class because it is used by the ModuleFormatTest01 unit test.
>>
>> An updated webrev is available at:
>>
>> http://cr.openjdk.java.net/~vinnie/6957907/webrev.01/
>
> Looks good to me, small nits:
>
> ModuleFileFormat:
>
> * import cleanup:
>
> I guess the  import java.security.cert.Certificate; could go away, too?

java.security.Certificate (deprecated) obscures 
java.security.cert.Certificate when package wildcards are used so
I normally import it explicitly.


>
> * loadCACertsStore:
>
> Not sure about the unix file separators and the file location on windows
> - if the file name is used across tests&  further code, it may make sense
> to add it to Files.java.

Slash separator works on Windows too.


>
> * SimpleLibrary
>
> indentation :
> +            if (doVerify) {
>               mr.verifyHashes();
> +            }

Fixed


>
> cheers,
> dalibor topic
>