Modules build minor cleanup
Dalibor Topic
Dalibor.Topic at Sun.COM
Wed Mar 17 16:17:39 PDT 2010
Mandy Chung wrote:
> On 03/17/10 15:55, Mandy Chung wrote:
>> Hi Dalibor,
>>
>> Can you take a look at the fix in the modules build?
>>
>> 1. It preinstalls the jdk modules in $outputdir
I have one question here:
in modularize:
154 for d in bin lib etc include ; do \
155 if [ -d $(TMP)/$$s/$$d ] ; then \
156 $(CP) -rf $(TMP)/$$s/$$d $$mlib; \
157 fi ; \
158 done \
159 fi ; \
the loop doesn't seem to copy resource files. Is that intentional?
>> 2. Not to include .map and .pdb files in the modules. We should
>> package the .map and .pdb files in some debug modules so that we can
>> install them for our debugging purpose.
Looks good.
> Forgot to mention this:
>
> 3. Not to include jmod and jpkg in the legacy image.
Looks good. I assume they are still available in the jdk-module-image?
cheers,
dalibor topic
--
*******************************************************************
Dalibor Topic Tel: (+49 40) 23 646 738
Java F/OSS Ambassador AIM: robiladonaim
Sun Microsystems GmbH Mobile: (+49 177) 2664 192
Nagelsweg 55 http://openjdk.java.net
D-20097 Hamburg mailto:Dalibor.Topic at sun.com
Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Amtsgericht München: HRB 161028
Geschäftsführer: Thomas Schröer
More information about the jigsaw-dev
mailing list