Modules build minor cleanup

[Mandy Chung]

Dalibor Topic wrote:
> Mandy Chung wrote:
>> On 03/17/10 15:55, Mandy Chung wrote:
>>> Hi Dalibor,
>>>
>>> Can you take a look at the fix in the modules build?
>>>
>>> 1. It preinstalls the jdk modules in $outputdir
>
> I have one question here:
>
> in modularize:
>
>  154                  for d in bin lib etc include ; do \
>  155                     if [ -d $(TMP)/$$s/$$d ] ; then \
>  156                        $(CP) -rf $(TMP)/$$s/$$d  $$mlib; \
>  157                     fi ; \
>  158                  done \
>  159               fi ; \
>
> the loop doesn't seem to copy resource files. Is that intentional?
>
classes and resources are handled in line 163-170.  This loop is to copy 
non-class and non-resource files from $outputdir/tmp/modules to the 
top-level module.   One or more modules defined in modules.config could 
be mapped in one top-level module.

>>> 2. Not to include .map and .pdb files in the modules.  We should 
>>> package the .map and .pdb files in some debug modules so that we can 
>>> install them for our debugging purpose.
>
> Looks good.
>
>> Forgot to mention this:
>>
>> 3. Not to include jmod and jpkg in the legacy image.
>
> Looks good. I assume they are still available in the jdk-module-image?
>
Right.  jmod is in {jdk,jre}-base-module and {jdk,jre}-module-image and 
jpkg is in jdk-{base,module}-image.

Mandy
> cheers,
> dalibor topic