Code review request for SecurityManager changes

Mandy Chung mandy.chung at oracle.com
Mon May 10 10:40:15 PDT 2010


Hi Sean,

The fix looks okay to me.

org/openjdk/jigsaw/Launcher.java
   line 94: nit: probably better to replace the test "".equals(s) with 
s.isEmpty().

test/org/openjdk/jigsaw/security.sh
   Can you add further comment in the @summary tag to describe what the 
test does?

Are you planning to look at the jigsaw APIs and add the proper @throws 
SecurityException (and the required security permission) in the spec at 
some point in time?

Thanks
Mandy

Sean Mullan wrote:
> See 
> http://cr.openjdk.java.net/~mullan/jigsaw/webrevs/SecurityManager/webrev.00/ 
> for an initial set of changes to allow modules to be run with a 
> SecurityManager.
>
> ModuleClassLoader now extends SecureClassLoader.
>
> There is no CodeSigner support yet. That will be coming later after we 
> integrate signed modules.
>
> Thanks,
> Sean
>




More information about the jigsaw-dev mailing list