Code review request for SecurityManager changes

[Sean Mullan]

On 5/10/10 1:40 PM, Mandy Chung wrote:
> Hi Sean,
>
> The fix looks okay to me.
>
> org/openjdk/jigsaw/Launcher.java
> line 94: nit: probably better to replace the test "".equals(s) with
> s.isEmpty().

Fixed.

>
> test/org/openjdk/jigsaw/security.sh
> Can you add further comment in the @summary tag to describe what the
> test does?

Fixed.

New webrev: 
http://cr.openjdk.java.net/~mullan/jigsaw/webrevs/SecurityManager/webrev.01

This also includes a fix for the first of Roger's comments. I need more time to 
think about the second comment; will look at it later.

>
> Are you planning to look at the jigsaw APIs and add the proper @throws
> SecurityException (and the required security permission) in the spec at
> some point in time?

Yes, I will look at that later this week.

--Sean

>
> Thanks
> Mandy
>
> Sean Mullan wrote:
>> See
>> http://cr.openjdk.java.net/~mullan/jigsaw/webrevs/SecurityManager/webrev.00/
>> for an initial set of changes to allow modules to be run with a
>> SecurityManager.
>>
>> ModuleClassLoader now extends SecureClassLoader.
>>
>> There is no CodeSigner support yet. That will be coming later after we
>> integrate signed modules.
>>
>> Thanks,
>> Sean
>>
>