Code review request for SecurityManager changes
Mark Reinhold
mr at sun.com
Tue May 11 10:14:31 PDT 2010
> Date: Mon, 10 May 2010 15:46:30 -0400
> From: sean.mullan at oracle.com
> New webrev:
> http://cr.openjdk.java.net/~mullan/jigsaw/webrevs/SecurityManager/webrev.01
Thanks -- these changes look good. Just a few minor stylistic comments,
so as to retain the style of the existing code in ModuleClassLoader.java
(line numbers in the new version in [brackets]):
[35] "extends SecureClassLoader" should be on its own line, as before
[49] Mark "todo" items with "##", not "ToDo:"
[50] Split long method invocations across multiple lines by splitting
the argument list rather than by separating the method name from the
argument list. This should read:
Class<?> c = super.defineClass(name, b, off, len,
new CodeSource(null),
new (CodeSigner[])null);
- Mark
More information about the jigsaw-dev
mailing list