Code review request for SecurityManager changes

Sean Mullan sean.mullan at oracle.com
Tue May 11 11:46:04 PDT 2010


On 5/11/10 1:14 PM, Mark Reinhold wrote:

>    [50] Split long method invocations across multiple lines by splitting
>    the argument list rather than by separating the method name from the
>    argument list.  This should read:
>
>      Class<?>  c = super.defineClass(name, b, off, len,
>                                     new CodeSource(null),
>                                     new (CodeSigner[])null);

Actually the CodeSource constructor has 2 arguments above. So which is preferable:

       Class<?>  c = super.defineClass(name, b, off, len,
                                       new CodeSource(null,
                                       (CodeSigner[])null);

or:

       Class<?>  c = super.defineClass(name, b, off, len,
                                       new CodeSource(null,
                                                      (CodeSigner[])null);

--Sean



More information about the jigsaw-dev mailing list