Review request: Install module content into zip files

[Mark Reinhold]

> Date: Fri, 28 May 2010 14:08:59 -0700
> From: mandy.chung at oracle.com

> I recently added make/modules/update_module.sh that also
> hardcodes the module library format. I can update it
> when this changeset is pushed to the jigsaw repo.

Okay.

>> @@ -168,28 +168,16 @@
>>  define import-from-modules-image
>>  ...
>> +    mdir=$(JDK_MODULES_LIB)/$$m/$(VERSION) ; \
>> +    if [ -f $$mdir/classes ] ; then \
>> +      $(BOOT_JAR_CMD) tf $$mdir/classes >$(TEMPDIR)/$$m.ls ; \
>> +      for p in $3 dummy ; do \
>> +        if $(GREP) $$p $(TEMPDIR)/$$m.ls >/dev/null; then \
>> +          $(ECHO) "Importing $$p from module $$m" ; \
>> +          (cd $1; $(BOOT_JAR_CMD) xvf $$mdir/classes $$p) ; \
>> +        fi ; \
>> +      done ; \
>> +    fi; \
>>    done ; \
>>  fi
>>  endef
> 
> I think Unjar should do the work.  Something like this:
> 
>  $(call Unjar,$1,$$mdir/classes,$3);

Okay, done, but as:  $(call Unjar,$1,$$mdir/classes,$$p)

Thanks,
- Mark