Review request: Install module content into zip files

[Mandy Chung]

Mark Reinhold wrote:
>>> @@ -168,28 +168,16 @@
>>>  define import-from-modules-image
>>>  ...
>>> +    mdir=$(JDK_MODULES_LIB)/$$m/$(VERSION) ; \
>>> +    if [ -f $$mdir/classes ] ; then \
>>> +      $(BOOT_JAR_CMD) tf $$mdir/classes >$(TEMPDIR)/$$m.ls ; \
>>> +      for p in $3 dummy ; do \
>>> +        if $(GREP) $$p $(TEMPDIR)/$$m.ls >/dev/null; then \
>>> +          $(ECHO) "Importing $$p from module $$m" ; \
>>> +          (cd $1; $(BOOT_JAR_CMD) xvf $$mdir/classes $$p) ; \
>>> +        fi ; \
>>> +      done ; \
>>> +    fi; \
>>>    done ; \
>>>  fi
>>>  endef
>>>       
>> I think Unjar should do the work.  Something like this:
>>
>>  $(call Unjar,$1,$$mdir/classes,$3);
>>     
>
> Okay, done, but as:  $(call Unjar,$1,$$mdir/classes,$$p)
>
>   

I was thinking that we don't need to check if the 
package exists in the module. Instead, something like this:

define import-from-modules-image
  if [ "$3" != "" ] ; then \
    for m in $2 dummy ; do \
      mdir=$(JDK_MODULES_LIB)/$$m/$(VERSION) ; \
      if [ -f $$mdir/classes ] ; then \
         $(call Unjar,$1,$$mdir/classes,$3); \
      fi ; \
    done ; \
  fi
endef


Mandy