Regrouping of jdk modules

[Alan Bateman]

Mandy Chung wrote:
>
>
> There are 40+ tools in the JDK, each of which needs to be a different
> module since a module only allows a single entry point in the current
> implementation.  I implemented a workaround in the launcher and add
> a special entry point in sun.launcher.LauncherHelper just for jdk tools
> to use so that multiple tools can be grouped in the same module.
> With this launcher change along with some other regrouping of the jdk
> modules, there are now 56 jdk modules.  The list is at:
>    http://cr.openjdk.java.net/~mchung/jigsaw/jdk-modules-list.txt
>
> Webrev:
>    http://cr.openjdk.java.net/~mchung/jigsaw/jdk-modules/
>
> Alan,
>    Can you review this set of changes?
>
> Summary of the jdk modules:
> 1. corba tools (orbd, tnameserv, servertools, and idlj) are included in
> the corba module.   idlj is a development tool and we may need to
> separate it from the corba runtime module.
>
> 2. rmid and rmiregistry are included in the rmi module as they are
> runtime tools.
>
> 3. kinit, klist, ktab are kerberos-related tools and included in the
> kerberos module
>
> 4. langtools has 7 modules (javac, apt, mirror, compiler, javadoc,
> javah and javap).
>
> 5. JRE tools will be in jdk.tools.jre and all other tools are grouped in
> jdk.tools.base, , jdk.tools.jaxws and jdk.tools.
>
> 6. Move the JMX RMI-IIOP connector and the JNDI cosnaming provider
> to corba module since they depend on corba to be present anyway.
>
> 7. Include prefs in the desktop module
>
> 8. com.sun.security.auth.callback.Dialog is grouped with the desktop
> module.
>
> 9. Group snmp in the management module
>
> 10. Merge all jaxp related modules into one single module
>
> 11. Include the JNDI providers (except cosnaming provider) in the
> jndi module.
>
> 12. Merge JAAS and SASL into the jaas module
>
> 13. A new jdk.ext module to include com.sun.* APIs (httpserver, sctp)
> when appropriate.
>
> Mandy
>
Sorry for the delay in reviewing this. Most of this looks reasonable to 
me, although the tool entry points will need to be re-visited once there 
is support for multiple entry points.

Should jdk.smartcardio be in the new jdk.ext module?  Also, I wonder if 
jdk/sun.security.acl should be moved into a jdk/sun.compat module also 
with what we have now in sun.legacy?

In the list for the endorsed standards override mechanism you have 
included jdk.jndi but I don't think JNDI is one of them. SAAJ is, but 
I'm not sure if you need to separate that out from the jaxws module.

A few comments on the other updates:

In java.c SetLauncherModule, is the _module_name check needed now?

Main nit in LauncherHelper but the @param tag doesn't need the "-" to 
separate the parameter name from its description.

I assume the updates to ProblemList.txt aren't supposed to be included.

That's it.

-Alan.