Regrouping of jdk modules

Mandy Chung mandy.chung at oracle.com
Fri Sep 10 08:06:57 PDT 2010


  On 9/10/10 4:02 AM, Alan Bateman wrote:
>
> Sorry for the delay in reviewing this. Most of this looks reasonable 
> to me, although the tool entry points will need to be re-visited once 
> there is support for multiple entry points.
>

Alan, thanks for the review.

> Should jdk.smartcardio be in the new jdk.ext module?  Also, I wonder 
> if jdk/sun.security.acl should be moved into a jdk/sun.compat module 
> also with what we have now in sun.legacy?
>

jdk.ext needs a better name.  It is a module for com.sun.* APIs 
(Oracle-extension to the platform).  It's not intended to cover modules 
used to install in the extensions directory.

JMX snmp adaptor (in sun.management module) depends on 
sun.security.acl.  We want to avoid having the core jdk modules to 
depend sun.legacy.  Another option is to keep JMX snmp as a standalone 
module.  I'll explore this in my next of modules change.

> In the list for the endorsed standards override mechanism you have 
> included jdk.jndi but I don't think JNDI is one of them. SAAJ is, but 
> I'm not sure if you need to separate that out from the jaxws module.
>

It's mistake moving jndi to that section.  For SAAJ, we can separate it 
out when it's determined the need for it.

> A few comments on the other updates:
>
> In java.c SetLauncherModule, is the _module_name check needed now?
>

Right. It's not needed now. I'll remove the check.
> Main nit in LauncherHelper but the @param tag doesn't need the "-" to 
> separate the parameter name from its description.
>

I'll clean up the nits.

> I assume the updates to ProblemList.txt aren't supposed to be included.
>
I will make sure this is not in the changeset. FYI.  It's a new problem 
list for testing module-image (ModuleProblemList.txt).

> That's it.
>
Thanks
Mandy



More information about the jigsaw-dev mailing list