Compressing class files in the module library

Mandy Chung mandy.chung at oracle.com
Thu Dec 1 11:33:42 PST 2011


On 11/28/2011 7:17 AM, Alan Bateman wrote:
>
> I've updated the patch [1] for the compression support to also add an 
> option to strip the debug attributes from classes when installing a 
> module.
>
> [1] http://cr.openjdk.java.net/~alanb/ModuleLibraryCompression/webrev/
>

Looks good overall.  Some minor comments:

SimpleLibrary.java
    L840: should it clean up and delete classes.pack temp file if 
IOException is thrown?

Defs-modules.gmk
    L140-143:  these flags might be more appropriate to define in
    make/common/share/Defs-java.gmk.  I assume these flags are used
    in all jmod create/install commands during the jdk build.  It might be
    better and less error-prone to define HOST_JMOD_CREATE_CMD
    and HOST_JMOD_INSTALL_CMD.

Mandy



More information about the jigsaw-dev mailing list