Compressing class files in the module library

[Alan Bateman]

On 01/12/2011 19:33, Mandy Chung wrote:
>
> Looks good overall.  Some minor comments:
>
> SimpleLibrary.java
>    L840: should it clean up and delete classes.pack temp file if 
> IOException is thrown?
If the install fails when it will be deleted (the !complete logic in the 
install method). We only need to explicitly remove the pack file when 
the stripping succeeds.

>
> Defs-modules.gmk
>    L140-143:  these flags might be more appropriate to define in
>    make/common/share/Defs-java.gmk.  I assume these flags are used
>    in all jmod create/install commands during the jdk build.  It might be
>    better and less error-prone to define HOST_JMOD_CREATE_CMD
>    and HOST_JMOD_INSTALL_CMD.
>
Currently it uses the options for all module libraries that the build 
generates but it should only be for the jre* images as it doesn't make 
sense to strip debug attributes from modules installed into the module 
library in jdk* image. For that reason I'd prefer not add to the 
HOST_JMOD* commands but instead add the options only where needed.

-Alan