Code review request for storing code signer info
Mandy Chung
mandy.chung at oracle.com
Thu Jan 13 12:30:35 PST 2011
On 01/13/11 07:52, Sean Mullan wrote:
> See
> http://cr.openjdk.java.net/~mullan/jigsaw/webrevs/jigsaw-certs/webrev.00/
>
org/openjdk/jigsaw/ModuleFileFormat.java
line 1744-1746: I think synchronization may not be an issue here as
module installation is done in a single thread.
line 1843:
jpkg takes the -k <keystore> option. I wonder if jmod should also
accept an alternative keystore location rather than using a system
property to override it. Or it is a requirement to use the system-wise
cacerts file?
line 1855-1858: it would be good to use try-with-resources.
test/org/openjdk/jigsaw/cli/jmod-signed.sh
line 85: Should we test both with and without the --noverify option?
The --noverify option was tested before this patch.
Otherwise, looks good.
Mandy
More information about the jigsaw-dev
mailing list