Code review request for storing code signer info

[Sean Mullan]

On 1/13/11 3:30 PM, Mandy Chung wrote:
> On 01/13/11 07:52, Sean Mullan wrote:
>> See http://cr.openjdk.java.net/~mullan/jigsaw/webrevs/jigsaw-certs/webrev.00/
>>
>
> org/openjdk/jigsaw/ModuleFileFormat.java
> line 1744-1746: I think synchronization may not be an issue here as module
> installation is done in a single thread.

Ok, I'll leave the code as is for now, but I'll add a code comment that we may 
need to synchronize this. There are actually several CertificateFactory objects 
instantiated at different layers of the code when verifying a signed module, so 
one of the things I also want to look at is whether it is possible to reduce 
that number and reuse the same CertificateFactory.

> line 1843:
> jpkg takes the -k <keystore> option. I wonder if jmod should also accept an
> alternative keystore location rather than using a system property to override
> it. Or it is a requirement to use the system-wise cacerts file?

It is not a requirement to use a system-wide cacerts file, but that should be 
the default in my opinion.

I'm not thrilled about using a system property but I also don't want to 
necessarily clutter the command line tool with additional options that should be 
rarely used.

Have we given any thought as to whether we will add some sort of configuration 
properties file to allow default settings to be overridden? There are other 
security defaults that will likely need to be overriden, such as revocation 
checking settings.

> line 1855-1858: it would be good to use try-with-resources.

Ah, you mean the Project Coin enhancement? Is there an example of code that uses 
this already that you can point me to?

> test/org/openjdk/jigsaw/cli/jmod-signed.sh
> line 85: Should we test both with and without the --noverify option? The
> --noverify option was tested before this patch.

Sure, I can add that back.

--Sean

>
> Otherwise, looks good.
>
> Mandy
>