Compressing class files in the module library
Chris Hegarty
chris.hegarty at oracle.com
Tue Nov 29 01:23:13 PST 2011
Looks good to me.
One minor comment. Not directly related to your change, but is the 'jmod
install ... -r resources' still required in Modules.gmk since Mandy's
recent change? Or should it just be removed?
That said, maybe I have an old build but it does look like the
'exploded' modules in the build, build/<os-arch>/modules, still put
stuff in the 'resources' directory. Is this now being missed in the jmod
files? I'll look into it.
-Chris.
On 11/28/11 03:17 PM, Alan Bateman wrote:
>
> I've updated the patch [1] for the compression support to also add an
> option to strip the debug attributes from classes when installing a
> module. This time the proposed option is -G and --strip-debug and it's
> an option on jmod install so it's on a per module basis (to allow for
> debugging of application modules that are installed into the same module
> library as modules that don't have debug attributes). For now the
> implementation uses pack200 so it's makes -G a bit more expensive than
> it should be. This is easily changed in the future if we have a general
> class reader/write in the platform.
>
> -Alan.
>
> [1] http://cr.openjdk.java.net/~alanb/ModuleLibraryCompression/webrev/
>
More information about the jigsaw-dev
mailing list