Review request: add TESTVMOPTS to jigsaw shell tests

[Alan Bateman]

On 12/04/2012 23:57, Mandy Chung wrote:
> The jigsaw shell tests currently ignore the VM options even if they 
> are set via jtreg options (e.g. -client, -server, -esa, -ea, -vmoption 
> or -vmoptions).  This patch fixes them up by adding TESTVMOPTS 
> environment variable [1] that will be set to the VM options passed 
> from the jtreg harness invocation:
>
> Webrev at:
>   http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/test-vm-opts/
These changes look okay to me (and as it happens, I've been looking for 
someone to do a pass over all the shell tests in the jdk repository to 
ensure that the VM options are passed through to VMs created by the 
scripts as sometimes we aren't testing exactly what is intended).

On -esa and -ea then they could be passed in via the jtreg -vmoption too 
but that would require changing test/Makefile and also it gets 
complicated when -J is required. So what you have is fine.

-Alan