Review request: add TESTVMOPTS to jigsaw shell tests

Mandy Chung mandy.chung at oracle.com
Fri Apr 13 07:33:09 PDT 2012


On 4/13/2012 3:42 AM, Alan Bateman wrote:
> These changes look okay to me (and as it happens, I've been looking 
> for someone to do a pass over all the shell tests in the jdk 
> repository to ensure that the VM options are passed through to VMs 
> created by the scripts as sometimes we aren't testing exactly what is 
> intended).
>

Thanks.  I notice that in the existing jdk regression tests too.

> On -esa and -ea then they could be passed in via the jtreg -vmoption 
> too but that would require changing test/Makefile and also it gets 
> complicated when -J is required. So what you have is fine.

test/Makefile always passes -esa -ea to jtreg.  We someones run the 
tests without jtreg during development - I thought it would be handy to 
set them by default (at least during this prototype).

Mandy



More information about the jigsaw-dev mailing list