Service provider module resolution <was> Re: Services/configuration/context webrevs
Paul Sandoz
paul.sandoz at oracle.com
Wed Aug 1 07:46:19 PDT 2012
On Jul 31, 2012, at 5:59 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
> On 7/9/2012 8:52 AM, Paul Sandoz wrote:
>> Hi,
>>
>> The following webrev fixes the nits. Many service-based tests are added to _Configurator.java, which makes most of the service-based *.sh tests redundant so those redundant ones removed. I added a runtime service-based test [*] that ensures correct behavior for all three ServiceLoader methods.
>>
>> http://cr.openjdk.java.net/~psandoz/jigsaw/resolver-services/webrev.3/
>
> Looks good.
Thanks for looking at this.
> It's good to see the service-based tests added to
> _Configurator.java and cleanup the services/*.sh tests. Minor comment:
>
> test/org/openjdk/jigsaw/_Configurator.java
> It might be worth adding a test to check that the service provider
> module's exported package is not visible to the service consumer module
> (e.g. x requires service S and the context("s at 1") has no remotePackage
> to the package exported by y that provides S.)
>
> L2: typo "2021" -> "2012"
>
http://cr.openjdk.java.net/~psandoz/jigsaw/resolver-services/webrev.4/
> ServiceLoaderTest.java
> nit: L116-118, L124-126, L132-134 - could be refactored out as a method.
> I'm fine if you prefer to leave it as it is.
>
I will leave it as is. If i let rip with TestNG :-) this could change.
>>
>>
>> I also added tests that show the permits behavior is general and not specific to services:
>>
>> ...
>
> Thanks for adding these tests. It's a general issue. As we discussed
> it offline today, it'll be addressed in a separate changeset. I know
> Alan is going to review it too. Once he reviews it, I can push this
> changeset for you.
>
OK, thanks,
Paul.
More information about the jigsaw-dev
mailing list