Allow remote repository to be located via non-http URI
Chris Hegarty
chris.hegarty at oracle.com
Mon Feb 13 06:42:01 PST 2012
On 13/02/2012 14:37, Alan Bateman wrote:
> On 13/02/2012 13:52, Chris Hegarty wrote:
>> This looks fine to me.
>>
>> Trivially, can the Files.move (RR.java L166 of new file) be moved into
>> the first try-catch? I just can't see that the separate try-catch is
>> necessary.
>>
>> -Chris.
> The file needs to be closed before moving it into place. It could be
D'oh! I knew there was a reason, just couldn't see it.
In which case, the change looks fine to me.
-Chris.
> done with an outer try-catch that does the recovery but instead it will
> require the try-with-resources to ensure that the file is closed before
> the move.
>
> -Alan
More information about the jigsaw-dev
mailing list