Allow remote repository to be located via non-http URI

Mandy Chung mandy.chung at oracle.com
Mon Feb 13 12:16:23 PST 2012


On 2/13/2012 5:10 AM, Alan Bateman wrote:
> Just to follow up this discussion. The issue with not cleaning up 
> after a failed attempt to add a remote repository is annoying so I've 
> put a patch to fix it here:
>
> http://cr.openjdk.java.net/~alanb/jigsaw-reporollback/webrev/
>

Looks good.

>
> The file needs to be closed before moving it into place. It could be 
> done with an outer try-catch that does the recovery but instead it 
> will require the try-with-resources to ensure that the file is closed 
> before the move.

Is it worth adding a comment in L166 to make this clear in the source?

Thanks
Mandy



More information about the jigsaw-dev mailing list