configuration being stored for modules that don't have entry points.

Alan Bateman Alan.Bateman at oracle.com
Wed Feb 22 08:44:04 PST 2012


Mandy - I need a sanity check on a minor change. The issue is that 
modules installed via install(Resolution,boolean) method are getting a 
stored configuration even when they don't have an entry point. I noticed 
this when chatting with David Holmes about the size of the jdk.tls 
module. In his environment the module was downloaded from a repository 
and so was installed via this install method that was larger than when 
installed from a jmod file. It's a clearly a policy issue as to whether 
we re-generate the configuration for all modules after installing some 
modules but as we do it when installing jmods then it's probably 
consistent to do the same here - do you agree?

-Alan

diff --git a/src/share/classes/org/openjdk/jigsaw/SimpleLibrary.java 
b/src/share/classes/org/openjdk/jigsaw/SimpleLibrary.java
--- a/src/share/classes/org/openjdk/jigsaw/SimpleLibrary.java
+++ b/src/share/classes/org/openjdk/jigsaw/SimpleLibrary.java
@@ -1486,9 +1486,7 @@

          // Configure
          //
-        Configuration<Context> cf
-            = Configurator.configure(this, res);
-        new StoredConfiguration(findModuleDir(root.id()), cf).store();
+       configure(null);
      }

      @Override




More information about the jigsaw-dev mailing list