configuration being stored for modules that don't have entry points.

[Mandy Chung]

Alan,

I agree with you that both of these install methods should be 
consistent.  As for your patch,  should it call 
configure(res.modulesNeeded()) instead of configure(null)? That's what 
the install(Collection<File>....) method calls.  Although the current 
implementation ignores the given mids for the installed modules, 
ultimately we want to re-generate the configurations according some 
policy which will probably be smart to take the list of installed 
modules into account.

On 2/22/2012 8:44 AM, Alan Bateman wrote:
> Mandy - I need a sanity check on a minor change. The issue is that 
> modules installed via install(Resolution,boolean) method are getting a 
> stored configuration even when they don't have an entry point. I 
> noticed this when chatting with David Holmes about the size of the 
> jdk.tls module. In his environment the module was downloaded from a 
> repository and so was installed via this install method that was 
> larger than when installed from a jmod file. 

It might be my issue of incorrect reading of the code - this install 
method (from a given Resolution) only configures one root module while 
the install from jmod files configures all root modules in the current 
prototype.  I would have thought it's smaller.  Probably I'm missing 
some key point here - can you help and explain?

Thanks
Mandy

> It's a clearly a policy issue as to whether we re-generate the 
> configuration for all modules after installing some modules but as we 
> do it when installing jmods then it's probably consistent to do the 
> same here - do you agree?
>
> -Alan
>
> diff --git a/src/share/classes/org/openjdk/jigsaw/SimpleLibrary.java 
> b/src/share/classes/org/openjdk/jigsaw/SimpleLibrary.java
> --- a/src/share/classes/org/openjdk/jigsaw/SimpleLibrary.java
> +++ b/src/share/classes/org/openjdk/jigsaw/SimpleLibrary.java
> @@ -1486,9 +1486,7 @@
>
>          // Configure
>          //
> -        Configuration<Context> cf
> -            = Configurator.configure(this, res);
> -        new StoredConfiguration(findModuleDir(root.id()), cf).store();
> +       configure(null);
>      }
>
>      @Override
>