RFR: Some intermittent org/openjdk/jigsaw test failures.

[Alan Bateman]

On 23/02/2012 10:53, Chris Hegarty wrote:
> Alan,
>
> I updated the webrev as per review comments and also fixed two more 
> failing tests ( and one was a "real" bug ;-) )
>
>  - Thread.sleep increased from 1 sec to 2 secs
>
>  - org/openjdk/jigsaw/cli/timestamp-test.sh fails on windows
>
>    SimpleLibrary.reIndex was not closing the handle to the modules
>    classes archive, therefore the test could not do its necessary
>    cleanup. I also removed some unnecessary args to jpkg in the test
>    and added a warning for easier diagnosability (arguably this could
>    be fatal).
>
>  - org/openjdk/jigsaw/cli/signed-modular-jar.sh
>
>    keystorePasswordURL did not contain the protocol scheme
>
> Updated webrev:
>   http://cr.openjdk.java.net/~chegar/jigsaw/tests_webrev.01/webrev/
>
In signed-module-jar.sh then ${SRC} is a file path, not a URL path this 
is still fragile.

In cli/TimestampTest.java then I assume that the reset method should 
check the return from deleteAll rather than checking if moduleDir exists 
again.

Otherwise I think this is fine and I'm happy to push it for you.

-Alan