RFR: Some intermittent org/openjdk/jigsaw test failures.

Chris Hegarty chris.hegarty at oracle.com
Thu Feb 23 13:13:48 PST 2012


On 02/23/12 01:35 PM, Alan Bateman wrote:
> .....
> In signed-module-jar.sh then ${SRC} is a file path, not a URL path this
> is still fragile.

   - test/org/openjdk/jigsaw/cli/signed-modular-jar.sh
     test/org/openjdk/jigsaw/cli/signed-module.sh

     I updated the above tests to correctly generate the URL from the
     given path.

     I started down the path of supporting paths with spaces! This is
     more work that I expected! If we really need it we can revisit it.

> In cli/TimestampTest.java then I assume that the reset method should
> check the return from deleteAll rather than checking if moduleDir exists
> again.

   Done.

> Otherwise I think this is fine and I'm happy to push it for you.

Updated Webrev:
   http://cr.openjdk.java.net/~chegar/jigsaw/tests_webrev.02/webrev/

-Chris.

> -Alan
>



More information about the jigsaw-dev mailing list