Example code in JDK8 requiring change for modular function

[Alan Bateman]

On 07/05/2012 09:52, Paul Sandoz wrote:
> On May 7, 2012, at 10:39 AM, Alan Bateman wrote:
>
>> On 07/05/2012 09:06, Paul Sandoz wrote:
>>> :
>>>
>>>> Implementation-wise it will require the base module to have "requires optional service java.nio.file.spi.FileTypeDetector" in its module declaration and the ServiceLoader usage changed as the legacy system class loader notion doesn't make sense when running with modules.
>>> FWIW i verified that is the case today in Jigsaw. Do the generated module-info.java files contain all known providers, or is there still some work to do here?
>> Non-static dependencies are a bit fragile at this point, and will be until we check in the module-info sources. For now it requires making sure that jdk/make/modules/jdk.depconfig is up to date. In this case the issue is that it's in jdk.depconfig as:
>>
>> @Provider(optional)
>>   java.nio.file.Files$DefaultFileTypeDetectorHolder ->  META-INF/services/java.nio.file.spi.FileTypeDetector
>>
>> but that's not the right inner class name anymore.  Apologies about that, I fixed lots of these when adding the services support but I missed this one.
>>
> If you have not already fixed it by the time you read this email i can do it.
I'll push a fix for it now so that we don't forget it.

-Alan