Heads up, BDB coming, needed to support fast configuration

[Mandy Chung]

On 5/10/2012 7:26 AM, Chris Hegarty wrote:
> Here is there webrev to support building of the bdb repository.
> http://cr.openjdk.java.net/~chegar/jigsaw/bdb_webrev.00/webrev/
>
> It builds on all platforms (even Mac and linux-arm!), with and without 
> the bdb repo where the system has the bdb develop package installed. 
> Partial builds that import from another JDK are still not implemented, 
> I'm not sure if this still makes sense going forward with the new 
> build system. Anyway, this requires further work, not a blocker for an 
> initial push.

Great, you built on all platforms + a bonus one (linux-arm)!  Have you 
tried SKIP_BOOT_CYCLE=false build?  You said "Partial builds that import 
from another JDK are still not implemented" - you mean it always 
requires building the entire forest unless USE_SYSTEM_BDB or 
ALT_BDB_IMPORT_PATH is specified, right?

I can push this for you when it's ready.  Minor comments:

jdk/make/common/Sanity.gmk
    Do we plan to enable BDB_IMPORT_CHECK some day to
    to check the library when make sanity

PersistentTreeMap.java
    L52: "is" a typo? nit: would be good to add a space after //
    L134: I assume the getStringAndInt method is a helper method
    for testing purpose only, right?  Might be worth to add a comment.

Thanks
Mandy