Heads up, BDB coming, needed to support fast configuration
Mandy Chung
mandy.chung at oracle.com
Fri May 11 09:32:58 PDT 2012
On 5/11/2012 7:07 AM, Chris Hegarty wrote:
>
>> L134: I assume the getStringAndInt method is a helper method
>> for testing purpose only, right? Might be worth to add a comment.
>
> Hmmm... I'm not sure about this. If it's ok, I'll leave it as it for
> now, we can revisit later if necessary.
I'm fine with what you have.
I asked this because I have a comment related to what Paul/Roger has
raised about the synchronized getStringAndInt method. I believe you
can move 'svala' and 'ivala' to the StringAndInt class as the instance
fields to get rid of the synchronization. The getStringAndInt method
can pass these fields of a newly created StringAndInt object to the get2
method call and StringAndInt class may provide the accessor methods to
get the key and value.
Mandy
More information about the jigsaw-dev
mailing list