Request for Review: minor VM class loading change

Mandy Chung mandy.chung at oracle.com
Thu May 17 12:48:53 PDT 2012


Karen,

On 5/17/12 9:51 AM, Karen Kinnear wrote:
> Please review a minor change for the VM to handle a non-null base module loader. I've also
> added a new (potentially temporary) API JVM_GetModuleLoader to allow us to incrementally clean up logic that assumes
> that JVM_GetClassLoader returns null for the bootclasspath.
>
> Within the VM, we will continue to use null to represent module classes loaded by the vm.
>
> http://cr.openjdk.java.net/~acorn/non-null-module-loader/webrev/

Looks good except in jni.cpp L397, the extra "NULL;" should be removed.

Thanks for the patch that sets up the basis for us to experiment with 
getClassLoader() to return null vs non-null for classes in jdk.base 
module (an open issue listed in [1]).  It'd be a step toward resolving 
this open issue.

Mandy
[1] http://openjdk.java.net/projects/jigsaw/doc/module-class-loading.pdf



More information about the jigsaw-dev mailing list