Review Request JDK-8171323: generate dot file for java.se and java.se.ee with only API dependences

[Paul Sandoz]

+1

(Took me a few takes on the patch to see you are substituting the embedded stream op in forEach into a map so you can filter on empty strings.)

Paul.


> On 16 Dec 2016, at 08:22, Mandy Chung <mandy.chung at oracle.com> wrote:
> 
> A small fix to the GenGraphs tool:
> 
> diff --git a/make/src/classes/build/tools/jigsaw/GenGraphs.java b/make/src/classes/build/tools/jigsaw/GenGraphs.java
> --- a/make/src/classes/build/tools/jigsaw/GenGraphs.java
> +++ b/make/src/classes/build/tools/jigsaw/GenGraphs.java
> @@ -214,13 +214,13 @@
> 
>             // same ranks
>             ranks.stream()
> -                .forEach(group -> out.format("{rank=same %s}%n",
> -                    descriptors.stream()
> +                .map(group -> descriptors.stream()
>                         .map(ModuleDescriptor::name)
>                         .filter(group::contains)
>                         .map(mn -> "\"" + mn + "\"")
> -                        .collect(joining(","))
> -                ));
> +                                         .collect(joining(",")))
> +                .filter(group -> group.length() > 0)
> +                .forEach(group -> out.format("{rank=same %s}%n", group));
> 
>             descriptors.stream()
>                 .filter(jdkGroup::contains)
> 
> Mandy
> 
>> On Dec 15, 2016, at 10:53 AM, Mandy Chung <mandy.chung at oracle.com> wrote:
>> 
>> This updates the GenGraphs build tool to generate a dot file for
>> `java.se` and `java.se.ee` modules including API dependences only
>> that can be used to display Java SE module graph.
>> 
>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8171323/webrev.00/
>> 
>> Mandy
>