Review Request JDK-8171323: generate dot file for java.se and java.se.ee with only API dependences
Alan Bateman
Alan.Bateman at oracle.com
Fri Dec 16 16:47:14 UTC 2016
On 16/12/2016 16:22, Mandy Chung wrote:
> A small fix to the GenGraphs tool:
>
> diff --git a/make/src/classes/build/tools/jigsaw/GenGraphs.java b/make/src/classes/build/tools/jigsaw/GenGraphs.java
> --- a/make/src/classes/build/tools/jigsaw/GenGraphs.java
> +++ b/make/src/classes/build/tools/jigsaw/GenGraphs.java
> @@ -214,13 +214,13 @@
>
> // same ranks
> ranks.stream()
> - .forEach(group -> out.format("{rank=same %s}%n",
> - descriptors.stream()
> + .map(group -> descriptors.stream()
> .map(ModuleDescriptor::name)
> .filter(group::contains)
> .map(mn -> "\"" + mn + "\"")
> - .collect(joining(","))
> - ));
> + .collect(joining(",")))
> + .filter(group -> group.length() > 0)
> + .forEach(group -> out.format("{rank=same %s}%n", group));
>
> descriptors.stream()
> .filter(jdkGroup::contains)
>
Looks good.
-Alan
More information about the jigsaw-dev
mailing list