RFR 8158736: Adapter class loaders can avoid creating named dynamic modules

Michael Haupt michael.haupt at oracle.com
Mon Jun 6 12:24:07 UTC 2016


Hi Sundar,

lower-case thumbs up!

Best,

Michael

> Am 06.06.2016 um 11:38 schrieb Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com>:
> 
> Please review: http://cr.openjdk.java.net/~sundar/8158736/webrev.00/ for
> https://bugs.openjdk.java.net/browse/JDK-8158736
> 
> Nashorn creates named, dynamic modules for java adapter classes. This
> can be avoided and we can use the default, unnamed module created for
> the adapter class loader. Nashorn allows only subtyping of public,
> exported supertypes be implemented in scripts.  The only package used in
> adapter module is exported and the adapter type is public as well.
> 
> There is no need for named dynamic module - as there is nothing to
> encapsulate.  Nashorn module can still selectively export packages to
> adapter module [ so that generated adapter class can access nashorn
> internals as needed].
> 
> This avoids having to generate read-links to the modules of the
> reference types used by the adapter class - because unnamed adapter
> module has read edges to all the modules.
> 
> Thanks,
> 
> -Sundar
> 

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment>	Oracle is committed to developing practices and products that help protect the environment



More information about the jigsaw-dev mailing list