RFR: JDK-8150998: Fix module dependences in java/lang tests
Roger Riggs
Roger.Riggs at Oracle.com
Wed Mar 2 18:35:34 UTC 2016
Hi Daniel,
fyi, there is a new TEST.properties file for the java/lang/management
tests that includes
the needed @modules = jdk.management.
Roger
On 3/2/2016 1:06 PM, Daniel Fuchs wrote:
> On 02/03/16 18:48, Alexandre (Shura) Iline wrote:
>> Hi.
>>
>> Could you please take a look on a fix to add missing module
>> dependencies for tests in java/lang.
>>
>> JDK9 changes:
>> http://cr.openjdk.java.net/~shurailine/8150998/webrev.jdk9.01
>> Jake changes:
>> http://cr.openjdk.java.net/~shurailine/8150998/webrev.jake.01
>>
>> Shura.
>>
>
> Hi Shura,
>
> I'm not sure I understand exactly the logic behind
> your proposed changes.
>
> I see for instance that you added @modules java.logging to tests
> that import java.util.logging APIs, but then removed
> @modules java.management to tests that are importing
> java.lang.management APIs?
>
> In what concern changes to the logging tests, there's a small
> inconsistency: I see that most of the test are using a
> single @modules clause, except for this one which has two @modules:
>
> http://cr.openjdk.java.net/~shurailine/8150998/webrev.jdk9.01/test/java/lang/System/LoggerFinder/internal/PlatformLoggerBridgeTest/PlatformLoggerBridgeTest.java.frames.html
>
>
> best regards,
>
> -- daniel
More information about the jigsaw-dev
mailing list