RFR: JDK-8150998: Fix module dependences in java/lang tests

[Alexandre (Shura) Iline]

> On Mar 2, 2016, at 10:06 AM, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
> 
> On 02/03/16 18:48, Alexandre (Shura) Iline wrote:
>> Hi.
>> 
>> Could you please take a look on a fix to add missing module dependencies for tests in java/lang.
>> 
>> JDK9 changes: http://cr.openjdk.java.net/~shurailine/8150998/webrev.jdk9.01
>> Jake changes: http://cr.openjdk.java.net/~shurailine/8150998/webrev.jake.01
>> 
>> Shura.
>> 
> 
> Hi Shura,
> 
> I'm not sure I understand exactly the logic behind
> your proposed changes.
> 
> I see for instance that you added @modules java.logging to tests
> that import java.util.logging APIs, but then removed
> @modules java.management to tests that are importing
> java.lang.management APIs?

Most of those tests were declaring dependencies to java.management, which is a compile-time dependency. What is actually needed for those tests to work is jdk.management module.

So, the dependency declaration needed to be changed anyway. Instead of fixing every test, I have declared the dependency in a newly added TEST.properties file, and removed @modules from tests altogether.

Module dependencies for a test are inherited from TEST.properties files above in the hierarchy, unless the test overrides @modules explicitly.

> 
> In what concern changes to the logging tests, there's a small
> inconsistency: I see that most of the test are using a
> single @modules clause, except for this one which has two @modules:
> 
> http://cr.openjdk.java.net/~shurailine/8150998/webrev.jdk9.01/test/java/lang/System/LoggerFinder/internal/PlatformLoggerBridgeTest/PlatformLoggerBridgeTest.java.frames.html

Indeed! Thank you!

Fixed:
http://cr.openjdk.java.net/~shurailine/8150998/webrev.jdk9.02/

Shura

> 
> best regards,
> 
> -- daniel