Review Request: 8178404: jlink --suggest-providers should list providers from observable modules

Alan Bateman Alan.Bateman at
Tue Apr 18 14:35:52 UTC 2017

On 13/04/2017 00:34, Mandy Chung wrote:

> Webrev:
> --suggest-providers should suggest providers from any observable modules
> rather than the resolved modules.  This patch also improves the output and
> fixes JDK-8178405 and JDK-8178327.  --add-modules has no effect to the
> suggested providers when —suggest-providers is specified.
This mostly looks good to me.

For the usage message then --suggest-providers might be simpler as 
"Suggest service providers that implement the given service type from 
the module path". The mention of `--add-modules` could confuse readers 
so I'd leave it out.

In passing, --bind-services currently prints "Do full service binding" 
and maybe we should change that to something "Automaticall link in 
service provider modules and their dependences" or something that is 
clearer than the current text.

Minor nit in L381 where the throw is indented too much, 
might be a tab.


More information about the jigsaw-dev mailing list