Proposal for New Functionality: Allow module-info merging in GenModuleInfoSource.java

[Adam Farley8]

Hi Alan,

After discussing the matter with Mandy, we agreed that the next step to 
resolve this issue should be to remove the need for this functionality in 
OpenJ9.

My reply didn't reach the list because it was rejected (posting blocked 
for
nonsubscribers). This has since been resolved.

Thanks for your time. :)

Best Regards

Adam Farley



From:   Alan Bateman <Alan.Bateman at oracle.com>
To:     Adam Farley8 <adam.farley at uk.ibm.com>
Cc:     mandy chung <mandy.chung at oracle.com>, jigsaw-dev at openjdk.java.net
Date:   11/12/2017 15:27
Subject:        Re: Proposal for New Functionality: Allow module-info 
merging in GenModuleInfoSource.java





On 06/12/2017 18:51, mandy chung wrote:
> Moving this to jigsaw-dev....
>
> On 12/6/17 8:38 AM, Adam Farley8 wrote:
>> Hi All,
>>
>> Currently, GenModuleInfoSource.java does not allow you to merge extra
>> module-info files into the primary module-info file (for a given 
module)
>> at build time.
>
> This tool intends to augment platform-specific 
> exports/opens/uses/provides but not requires.  It was a design choice 
> we made that JDK modules are expected to have the same dependences for 
> all platforms.
Right, more specifically the `requires transitive` should never be 
different.

If there is use-case where the implementation is so different that it 
needs `requires` in the .extra file then it can be done but the 
augmenting would need to be done before the build computes the ordering 
that the modules are compiled (the modules are compiled in reserve 
topological order as Mandy knows).

-Alan





Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU