[9] Review request: JDK-8170200: Packager Redistributable Module List Unit Test
Kevin Rushforth
kevin.rushforth at oracle.com
Tue Feb 7 19:51:10 UTC 2017
If the test is in the FX repo then it wouldn't be able to check the
jmod, but would have to check some intermediate data that feeds into the
jmod. That might be OK, but is seems easy enough to check for the
existence of the jdk.packager module and skip the test if not present.
-- Kevin
Mandy Chung wrote:
> Should this test be in the FX repo where jdk.packager resides? I would think so. This test should only run with the build with FX modules.
>
> Mandy
>
>
>> On Feb 7, 2017, at 10:32 AM, Victor Drozdov <victor.drozdov at oracle.com> wrote:
>>
>> Kevin, Mandy,
>>
>> Please review my new unit test for javapackager. It reads redistributable module list from jdk.packager, if a module in the list doesn't exist, then the test fails.
>>
>> JIRA: https://bugs.openjdk.java.net/browse/JDK-8170200
>> Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8170200/webrev.00/
>>
>> --Victor
>>
>>
>
>
More information about the jigsaw-dev
mailing list