8173393: Module system implementation refresh (2/2017)
    Mandy Chung 
    mandy.chung at oracle.com
       
    Wed Feb  8 20:46:17 UTC 2017
    
    
  
I reviewed your updated webrev:
  http://cr.openjdk.java.net/~alanb/8173393/2
src/jdk.jdeps/share/classes/com/sun/tools/jdeps/Module.java
 285             m.descriptor.packages().forEach(builder::opens);
This is not needed.  I took it out.
We probably will do another pass on the APIs to tag with @spec JPMS.  IllegalCallerException and the following in MethodHandles don’t have the tag.
 667         public static final int UNCONDITIONAL = PACKAGE << 2;
 841         public Lookup dropLookupMode(int modeToDrop) {
IIRC no specific spec change to ResourceBundle.Control.toBundleName. So @revised and @spec can be dropped.
Otherwise looks fine to me. I reviewed changes in jdk.jdeps in langtools and all other repos.
Mandy 
    
    
More information about the jigsaw-dev
mailing list