Review Request: JDK-8173374: Update GenGraphs tool to generate dot graph with requires transitive edges

[Daniel Fuchs]

Hi Mandy,

Some early comments:

GenGraphs.java
--------------

   58                 dir = Paths.get(args[++i]);

may produced ArrayOutOfBoundsException - should we have better
error reporting?
Or should it check && i < args.length - 1 so that it falls back
to having dir == null below?

   93 
.resolve(ModuleFinder.ofSystem(),

could that be: .resolve(finder,


Graph.java
----------

  119         return builder.build().reduce();
  277             this.nodes.addAll(nodes);


These were bugs, which you're taking this opportunity to fix - right?


JdepsTask.java:
---------------

1027                 // print module descriptor

Is this comment accurate?

DotFileTest.java
----------------

Missing @bug tag?

best regards,

-- daniel

On 15/02/17 00:28, Mandy Chung wrote:
> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173374/webrev.00/
>
> This is the first step to enable generating dot graph to be
> included in module summary javadoc, if desired.  jdeps already
> supports generating the dot graph for modules.  This patch
> converts GenGraphs build tool to use jdeps implementation
> as well as fixes jdeps to work with -apionly to generate
> a dot graph containing `requires transitive` edges only.
>
> Mandy
> [1] https://bugs.openjdk.java.net/browse/JDK-8173303
>