Some suggested patches and improvements

Michael Rasmussen michael.rasmussen at
Fri May 12 20:52:56 UTC 2017

On 12 May 2017 at 11:22, Alan Bateman <Alan.Bateman at> wrote:
> However for #3 then you've
> missed several important error cases, e.g. illegal package names, or the
> package is already in another module defined to the class loader.

These checks are already present in implAddPackage, so why duplicate
those checks in the wrapping method?

Speaking of, the package name check in implAddPackage seems
incomplete. addPackage("some...pkg") would pass the check, but it's
shouldn't be legal, as it contains empty segments.


More information about the jigsaw-dev mailing list