RFR: 8214230: Classes generated by SystemModulesPlugin.java are not reproducable

Alan Bateman Alan.Bateman at oracle.com
Wed Nov 28 15:01:36 UTC 2018


On 28/11/2018 13:49, Claes Redestad wrote:
> Hi Erik,
>
> looks good to me!
>
> (Nit) You could consider the old TreeMap trick to ensure key-sorted 
> map iteration order:
>
> // convert to a TreeMap to ensure sorted iteration order for (var e : 
> new TreeMap<>(map).entrySet()) { Thanks!
>
I agree TreeMap would be simpler in generate method where we should just 
need to change "locals" to be a TreeMap rather than a HashMap. The rest 
looks okay to me.

-Alan


More information about the jigsaw-dev mailing list