RFR: 8214230: Classes generated by SystemModulesPlugin.java are not reproducable

Erik Helin erik.helin at oracle.com
Thu Nov 29 08:47:58 UTC 2018


Alan, Claes, Mandy,

thank you all for your quick reviews, appreciate it.

On 11/28/2018 04:01 PM, Alan Bateman wrote:
> On 28/11/2018 13:49, Claes Redestad wrote:
>> (Nit) You could consider the old TreeMap trick to ensure key-sorted 
>> map iteration order:
>>
>> // convert to a TreeMap to ensure sorted iteration order for (var e : 
>> new TreeMap<>(map).entrySet()) { Thanks!
>>
> I agree TreeMap would be simpler in generate method where we should just 
> need to change "locals" to be a TreeMap rather than a HashMap.

I agree as well, nice suggestion Claes! Please see updated patches below:

- incremental: http://cr.openjdk.java.net/~ehelin/8214230/00-01/
- full: http://cr.openjdk.java.net/~ehelin/8214230/01/

Re-tested that this works as expected on Linux x86-64 by running the new 
JTReg test.

Thanks,
Erik


More information about the jigsaw-dev mailing list