Review request for JMC-6114: Fixing spotbugs violation (false positive) in LocalJVMToolkit

[Sharath Ballal]

Hi Marcus,

Though vm may not be null all the time, if it is null we will still try to detach.  Is there a reason why you don’t want to check the vm for NULL before detaching ?

Thanks,
Sharath


-----Original Message-----
From: Jayathirth D V 
Sent: Thursday, August 16, 2018 3:39 PM
To: Marcus Hirt; jmc-dev at openjdk.java.net
Subject: RE: Review request for JMC-6114: Fixing spotbugs violation (false positive) in LocalJVMToolkit

Hi Marcus,

Changes are fine.
Before the change browser.attach test was causing "mvn verify" to fail.
After the change "mvn verify" passes.

Thanks,
Jay

-----Original Message-----
From: Marcus Hirt 
Sent: Monday, August 13, 2018 3:19 PM
To: jmc-dev at openjdk.java.net
Subject: Review request for JMC-6114: Fixing spotbugs violation (false positive) in LocalJVMToolkit

Hi all,

Please review this small fix to get the tests to run properly.

Jira:   https://bugs.openjdk.java.net/browse/JMC-6114
Webrev: http://cr.openjdk.java.net/~hirt/JMC-6114/webrev.01/

Kind regards,
Marcus