[Rev 06] RFR: 6554: Support JFR in OpenJDK 8

[Henrik Dafgård]

On Mon, 16 Dec 2019 12:45:43 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> This is for OpenJDK 8 implementations that have backported JFR, e.g. Azul's JDK. There is also a backport effort for OpenJDK 8 in general.
> 
> The pull request has been updated with 1 additional commit.

application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/JVMSupportToolkitTest.java line 50:

> 49: public class JVMSupportToolkitTest {
> 50: 	private static final String ORACLE = "Oracle";
> 51: 	// FIXME: Add tests for the methods that take IConnectionHandle as a parameter.

Non-blocking, but we might want to name this a little more descriptively, like VENDOR_ORACLE?

application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/JVMSupportToolkitTest.java line 136:

> 135: 		ServerHandle server = new ServerHandle(
> 136: 				new ServerDescriptor(null, null, new JVMDescriptor("1.8.0", JVMType.HOTSPOT, JVMArch.UNKNOWN, "OpenJDK",
> 137: 						null, null, null, false, null)),

If we have made Oracle a constant, we should make "OpenJDK" one too.

-------------

Marked as reviewed by hdafgard (Reviewer).

PR: https://git.openjdk.java.net/jmc/pull/19