[Rev 06] RFR: 6554: Support JFR in OpenJDK 8

[Mario Torre]

Those are good points.

I think Marcus hasn't pushed this yet so maybe we can have those fixed
in the pull request.

Cheers,
Mario

On Mon, Dec 16, 2019 at 1:46 PM Henrik Dafgård
<hdafgard at openjdk.java.net> wrote:
>
> On Mon, 16 Dec 2019 12:45:43 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>
> >> This is for OpenJDK 8 implementations that have backported JFR, e.g. Azul's JDK. There is also a backport effort for OpenJDK 8 in general.
> >
> > The pull request has been updated with 1 additional commit.
>
> application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/JVMSupportToolkitTest.java line 50:
>
> > 49: public class JVMSupportToolkitTest {
> > 50:   private static final String ORACLE = "Oracle";
> > 51:   // FIXME: Add tests for the methods that take IConnectionHandle as a parameter.
>
> Non-blocking, but we might want to name this a little more descriptively, like VENDOR_ORACLE?
>
> application/tests/org.openjdk.jmc.rjmx.test/src/test/java/org/openjdk/jmc/rjmx/test/JVMSupportToolkitTest.java line 136:
>
> > 135:          ServerHandle server = new ServerHandle(
> > 136:                          new ServerDescriptor(null, null, new JVMDescriptor("1.8.0", JVMType.HOTSPOT, JVMArch.UNKNOWN, "OpenJDK",
> > 137:                                          null, null, null, false, null)),
>
> If we have made Oracle a constant, we should make "OpenJDK" one too.
>
> -------------
>
> Marked as reviewed by hdafgard (Reviewer).
>
> PR: https://git.openjdk.java.net/jmc/pull/19
>


-- 
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898